Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Set common initial covariance for vertex fitting #2947

Merged

Conversation

andiwand
Copy link
Contributor

Values take from

finderConfig.initialVariances << 1e+2, 1e+2, 1e+2, 1e+8;

@andiwand andiwand added this to the next milestone Feb 14, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Vertexing labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9eac779) 48.85% compared to head (3f6b82f) 48.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2947   +/-   ##
=======================================
  Coverage   48.85%   48.85%           
=======================================
  Files         495      495           
  Lines       28897    28897           
  Branches    13726    13726           
=======================================
  Hits        14117    14117           
  Misses       4891     4891           
  Partials     9889     9889           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit fc68c59 into acts-project:main Feb 15, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants