fix: Fix truth matching in TruthVertexFinder in Examples
#2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
github-actions
bot
added
Infrastructure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2937 +/- ##
=======================================
Coverage 48.78% 48.78%
=======================================
Files 493 493
Lines 28914 28914
Branches 13752 13752
=======================================
Hits 14105 14105
Misses 4909 4909
Partials 9900 9900 ☔ View full report in Codecov by Sentry. |
This reverts commit 2ec4ea3.
github-actions
bot
removed
Infrastructure
📊: Physics performance monitoring for b690dc4physmon summary
|
andiwand
changed the title
TruthVertexFinder in Examples
andiwand
commented
Feb 13, 2024
andiwand
commented
Feb 13, 2024
Examples/Algorithms/Vertexing/include/ActsExamples/Vertexing/VertexFitterAlgorithm.hpp
Outdated
Show resolved
Hide resolved
paulgessinger
changed the title
TruthVertexFinder in ExamplesTruthVertexFinder in Examples
paulgessinger
approved these changes
Feb 20, 2024
andiwand
added a commit
to andiwand/acts
that referenced
this pull request
Feb 21, 2024
…ect#2937) Our vertex truth finding relied on the fact that we have one track for each selected particle which can only be achieved in some truth tracking cases. I generalized this by truth matching the tracks first and then grouping the tracks to the truth vertices. This can be used to isolate vertex fitter performance. Note that the fitter will always be full billoir for now. This could be extended to AMVF in the future.
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
This fixes an overlook in #2937. Non reconstructed particles result in an exception which is fixed here
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ect#2937) Our vertex truth finding relied on the fact that we have one track for each selected particle which can only be achieved in some truth tracking cases. I generalized this by truth matching the tracks first and then grouping the tracks to the truth vertices. This can be used to isolate vertex fitter performance. Note that the fitter will always be full billoir for now. This could be extended to AMVF in the future.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…oject#2979) This fixes an overlook in acts-project#2937. Non reconstructed particles result in an exception which is fixed here
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ect#2937) Our vertex truth finding relied on the fact that we have one track for each selected particle which can only be achieved in some truth tracking cases. I generalized this by truth matching the tracks first and then grouping the tracks to the truth vertices. This can be used to isolate vertex fitter performance. Note that the fitter will always be full billoir for now. This could be extended to AMVF in the future.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…oject#2979) This fixes an overlook in acts-project#2937. Non reconstructed particles result in an exception which is fixed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our vertex truth finding relied on the fact that we have one track for each selected particle which can only be achieved in some truth tracking cases.
I generalized this by truth matching the tracks first and then grouping the tracks to the truth vertices.
This can be used to isolate vertex fitter performance.
Note that the fitter will always be full billoir for now. This could be extended to AMVF in the future.