Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Use BasePropagator interface in vertexing #2886

Merged
merged 13 commits into from
Feb 15, 2024
Merged

refactor!: Use BasePropagator interface in vertexing #2886

merged 13 commits into from
Feb 15, 2024

Conversation

paulgessinger
Copy link
Member

This PR untemplates the ImpactParameterEstimator, HelicalTrackLinearizer and NumericalTrackLinearizer

Part of:

Blocked by:

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Jan 22, 2024
@paulgessinger paulgessinger added this to the v33.0.0 milestone Jan 22, 2024
@paulgessinger paulgessinger mentioned this pull request Jan 22, 2024
Closed
1 task
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing labels Jan 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (55d49ec) 48.84% compared to head (fc17517) 48.85%.

Files Patch % Lines
...re/include/Acts/Vertexing/ImpactPointEstimator.ipp 60.00% 0 Missing and 10 partials ⚠️
.../include/Acts/Vertexing/HelicalTrackLinearizer.ipp 42.85% 1 Missing and 3 partials ⚠️
...nclude/Acts/Vertexing/NumericalTrackLinearizer.ipp 42.85% 0 Missing and 4 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.hpp 0.00% 0 Missing and 2 partials ⚠️
.../include/Acts/Vertexing/HelicalTrackLinearizer.hpp 50.00% 1 Missing and 1 partial ⚠️
...e/include/Acts/Vertexing/IterativeVertexFinder.hpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2886   +/-   ##
=======================================
  Coverage   48.84%   48.85%           
=======================================
  Files         495      495           
  Lines       28909    28897   -12     
  Branches    13732    13726    -6     
=======================================
- Hits        14122    14117    -5     
- Misses       4890     4891    +1     
+ Partials     9897     9889    -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

📊: Physics performance monitoring for fc17517

Full contents

physmon summary

@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part5-use-base-propagator branch 2 times, most recently from 7a1cad0 to a9da8d1 Compare January 24, 2024 12:04
@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part5-use-base-propagator branch 9 times, most recently from 3138e97 to cf08389 Compare February 8, 2024 11:10
@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part5-use-base-propagator branch from cf08389 to d20ac6c Compare February 14, 2024 10:29
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Feb 14, 2024
@paulgessinger paulgessinger marked this pull request as ready for review February 14, 2024 10:29
@paulgessinger
Copy link
Member Author

This is ready now, @andiwand

@paulgessinger paulgessinger mentioned this pull request Feb 14, 2024
Merged
andiwand
andiwand previously approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please!

Core/include/Acts/Vertexing/HelicalTrackLinearizer.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Vertexing/HelicalTrackLinearizer.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Vertexing/NumericalTrackLinearizer.ipp Outdated Show resolved Hide resolved
@paulgessinger
Copy link
Member Author

Updated @andiwand

andiwand
andiwand previously approved these changes Feb 14, 2024
View reviewed changes
@paulgessinger
Copy link
Member Author

Had some clang-tidy complains, let's see what it says now!

@andiwand andiwand merged commit 9eac779 into acts-project:main Feb 15, 2024
54 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [9eac779]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Feb 15, 2024
@paulgessinger paulgessinger deleted the refactor/vtx-templates-part5-use-base-propagator branch February 15, 2024 10:39
kodiakhq bot pushed a commit that referenced this pull request Feb 16, 2024
@paulgessinger
refactor!: Use Delegate for track linearizers (#2946)
0002567 
This allows removing the linearizer template from: 
- Billoir fitter
- ZScan finder
- IVF
- AMVFitter

Part of:
- #2842 

Blocked by:
- #2886
@paulgessinger paulgessinger added Breaks Athena build This PR breaks the Athena build and removed Breaks Athena build This PR breaks the Athena build labels Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@paulgessinger @kodiakhq @EleniXoch
refactor!: Use BasePropagator interface in vertexing (acts-project#2886)
1952943 
This PR untemplates the ImpactParameterEstimator, HelicalTrackLinearizer
and NumericalTrackLinearizer

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2881

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@paulgessinger @EleniXoch
refactor!: Use Delegate for track linearizers (acts-project#2946)
0837bbb 
This allows removing the linearizer template from: 
- Billoir fitter
- ZScan finder
- IVF
- AMVFitter

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2886
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@paulgessinger @kodiakhq @asalzburger
refactor!: Use BasePropagator interface in vertexing (acts-project#2886)
af5634f 
This PR untemplates the ImpactParameterEstimator, HelicalTrackLinearizer
and NumericalTrackLinearizer

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2881

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@paulgessinger @asalzburger
refactor!: Use Delegate for track linearizers (acts-project#2946)
8a62677 
This allows removing the linearizer template from: 
- Billoir fitter
- ZScan finder
- IVF
- AMVFitter

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing
Projects
None yet
Milestone
v33.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @andiwand