Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Untemplate VertexInfo and VertexingOptions #2878

Merged
merged 4 commits into from
Feb 6, 2024
Merged

refactor!: Untemplate VertexInfo and VertexingOptions #2878

merged 4 commits into from
Feb 6, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Jan 18, 2024 •
edited
Loading

@paulgessinger paulgessinger added this to the next milestone Jan 18, 2024
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Jan 18, 2024
@paulgessinger paulgessinger marked this pull request as draft January 18, 2024 09:53
@paulgessinger paulgessinger mentioned this pull request Jan 18, 2024
Closed
1 task
@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Vertexing labels Jan 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c2e1e6e) 48.99% compared to head (5f9a8fd) 48.99%.

❗ Current head 5f9a8fd differs from pull request most recent head 864226e. Consider uploading reports for the commit 864226e to get more accurate results

Files Patch % Lines
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 0.00% 1 Missing and 2 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2878   +/-   ##
=======================================
  Coverage   48.99%   48.99%           
=======================================
  Files         495      496    +1     
  Lines       28937    28939    +2     
  Branches    13704    13704           
=======================================
+ Hits        14178    14179    +1     
- Misses       4881     4882    +1     
  Partials     9878     9878

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

📊: Physics performance monitoring for 864226e

Full contents

physmon summary

@paulgessinger paulgessinger force-pushed the refactor/untemplate-vertex-info-options branch from 98254dc to 6e0bf34 Compare January 18, 2024 17:09
@paulgessinger paulgessinger mentioned this pull request Jan 18, 2024
Merged
@paulgessinger paulgessinger force-pushed the refactor/untemplate-vertex-info-options branch 2 times, most recently from 6c01bbe to 165d9a3 Compare January 22, 2024 08:26
@github-actions github-actions bot removed the Infrastructure Changes to build tools, continous integration, ... label Jan 22, 2024
@paulgessinger paulgessinger force-pushed the refactor/untemplate-vertex-info-options branch 2 times, most recently from 736ca06 to 874a9ca Compare January 24, 2024 12:04
@paulgessinger paulgessinger force-pushed the refactor/untemplate-vertex-info-options branch 3 times, most recently from 08f49e6 to c58715a Compare February 5, 2024 09:47
@andiwand
Copy link
Contributor

andiwand commented Feb 6, 2024

I guess this is the next one in the list @paulgessinger ?

@paulgessinger paulgessinger force-pushed the refactor/untemplate-vertex-info-options branch from c58715a to 5f9a8fd Compare February 6, 2024 08:59
@paulgessinger paulgessinger marked this pull request as ready for review February 6, 2024 09:00
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Feb 6, 2024
andiwand
andiwand previously approved these changes Feb 6, 2024
View reviewed changes
@kodiakhq kodiakhq bot merged commit c907d17 into acts-project:main Feb 6, 2024
51 checks passed
@github-actions github-actions bot removed the automerge label Feb 6, 2024
@acts-project-service
Copy link
Collaborator

acts-project-service commented Feb 6, 2024 •
edited
Loading

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Feb 6, 2024
kodiakhq bot pushed a commit that referenced this pull request Feb 8, 2024
@paulgessinger
refactor!: Remove input_track_t template parameters (#2880)
89858d9 
This PR should completely remove the use of `input_track_t`.

Part of:
- #2842 

Blocked by:
- #2878
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@paulgessinger @LaraCalic
refactor!: Untemplate VertexInfo and VertexingOptions (acts-proje…
86cc008 
…ct#2878)

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2877
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@paulgessinger @LaraCalic
refactor!: Remove input_track_t template parameters (acts-project#2880
f496bb0 
)

This PR should completely remove the use of `input_track_t`.

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2878
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
@paulgessinger paulgessinger added Breaks Athena build This PR breaks the Athena build and removed Breaks Athena build This PR breaks the Athena build labels Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@paulgessinger @EleniXoch
refactor!: Untemplate VertexInfo and VertexingOptions (acts-proje…
9602276 
…ct#2878)

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2877
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@paulgessinger @EleniXoch
refactor!: Remove input_track_t template parameters (acts-project#2880
08b14eb 
)

This PR should completely remove the use of `input_track_t`.

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2878
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@paulgessinger @asalzburger
refactor!: Untemplate VertexInfo and VertexingOptions (acts-proje…
40485d2 
…ct#2878)

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2877
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@paulgessinger @asalzburger
refactor!: Remove input_track_t template parameters (acts-project#2880
acca93e 
)

This PR should completely remove the use of `input_track_t`.

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing
Projects
None yet
Milestone
v33.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @andiwand @acts-project-service