fix: Document and fix IWYU #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
AJPfleger
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Could you also change some typos in https://github.com/acts-project/acts/blob/main/CI/iwyu/filter.yaml ? :)
📊: Physics performance monitoring for bc9da5aphysmon summary
|
AJPfleger
previously approved these changes
Dec 5, 2023
andiwand
force-pushed
the
doc-and-fix-iwyu
branch
from
5f91efd
to
b201442
Compare
acts-policybot
bot
dismissed
AJPfleger’s stale review
Invalidated by push of b201442
AJPfleger
approved these changes
Dec 5, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
- Coverage 49.50% 49.50% -0.01%
==========================================
Files 474 474
Lines 27068 27072 +4
Branches 12511 12511
==========================================
Hits 13401 13401
- Misses 4761 4765 +4
Partials 8906 8906 ☔ View full report in Codecov by Sentry. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
#2765 was not sufficient looking at https://github.com/acts-project/acts/actions/runs/7102359442/job/19332529370 we really need an absolute path https://github.com/acts-project/acts/actions/runs/7103710691/job/19337031841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding some documentation and fix the params