-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove representation
from ObjectIntersection
#2760
refactor: Remove representation
from ObjectIntersection
#2760
Conversation
ObjectIntersection
ObjectIntersection
representation
from ObjectIntersection
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2760 +/- ##
==========================================
- Coverage 49.50% 49.48% -0.02%
==========================================
Files 474 474
Lines 27072 27069 -3
Branches 12511 12513 +2
==========================================
- Hits 13401 13395 -6
Misses 4765 4765
- Partials 8906 8909 +3 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for eb19356physmon summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me!
Seems some webhooks were missed. Merging this manually! |
As the templating of the representing object was rather a burden in #2625 I propose to remove it all together and compose the intersection if necessary. Here I used a
std::pair
in theNavigator
for composition for now which may be not optimal but it works as it should for now