fix: Fix trapezoid accelerated inside check

Core/include/Acts/Surfaces/TrapezoidBounds.hpp

@@ -30,7 +30,6 @@ namespace Acts {
 /// @image html TrapezoidBounds.gif
 ///
 /// @todo can be speed optimized by calculating kappa/delta and caching it
-
 class TrapezoidBounds : public PlanarBounds {
  public:
   enum BoundValues {

Core/src/Surfaces/TrapezoidBounds.cpp

@@ -32,18 +32,31 @@ bool Acts::TrapezoidBounds::inside(const Acts::Vector2& lposition,
     double tolX = bcheck.tolerance()[eBoundLoc0];
     double tolY = bcheck.tolerance()[eBoundLoc1];
 
-    if (std::abs(y) - hlY > tolY) {
-      // outside y range
+    double distY = std::abs(y) - hlY;
+
+    // check outside y range + tolerance
+    if (distY > tolY) {
       return false;
     }
 
-    if (std::abs(x) - std::max(hlXnY, hlXpY) > tolX) {
-      // outside x range
+    // distance x to outer rectangle
+    double distOuterX = std::abs(x) - std::max(hlXnY, hlXpY);
+
+    // check outside x range + tolerance
+    if (distOuterX > tolX) {
       return false;
     }
 
-    if (std::abs(x) - std::min(hlXnY, hlXpY) <= tolX) {
-      // inside x range
+    // distance x to inner rectangle
+    double distInnerX = std::abs(x) - std::min(hlXnY, hlXpY);
+
+    // check inside x range, inside y range + tolerance (already checked above)
+    if (distInnerX <= 0) {
+      return true;
+    }
+
+    // check inside x range + tolerance, inside y range
+    if ((distInnerX <= tolX) && (distY <= 0)) {
       return true;
     }
   }