test: Use deterministic RNG for tests #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
previously approved these changes
Nov 17, 2023
|
of course this fails a unit test 😄 |
This was referenced Nov 18, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
=======================================
Coverage 49.56% 49.56%
=======================================
Files 474 474
Lines 26928 26928
Branches 12422 12422
=======================================
Hits 13348 13348
Misses 4751 4751
Partials 8829 8829 ☔ View full report in Codecov by Sentry. |
AJPfleger
previously approved these changes
Nov 18, 2023
andiwand
added
🛑 blocked
acts-policybot
bot
dismissed
AJPfleger’s stale review
Invalidated by push of caf87cb
github-actions
bot
added
Component - Examples
acts-policybot
bot
dismissed
AJPfleger’s stale review
Invalidated by push of e5fe692
AJPfleger
approved these changes
Nov 20, 2023
andiwand
changed the title
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
acts-project-service
added
the
Fails Athena tests
LaraCalic
added a commit
to LaraCalic/acts
that referenced
this pull request
Dec 2, 2023
apparently otherwise the random engine can be different on different platforms which I observed in acts-project#2625 with macos at the same time I hardcoded the type for the `std::uniform_int_distribution`. apparently this can also make a difference for the random value
LaraCalic
added a commit
to LaraCalic/acts
that referenced
this pull request
Dec 11, 2023
apparently otherwise the random engine can be different on different platforms which I observed in acts-project#2625 with macos at the same time I hardcoded the type for the `std::uniform_int_distribution`. apparently this can also make a difference for the random value
LaraCalic
added a commit
to LaraCalic/acts
that referenced
this pull request
Dec 18, 2023
apparently otherwise the random engine can be different on different platforms which I observed in acts-project#2625 with macos at the same time I hardcoded the type for the `std::uniform_int_distribution`. apparently this can also make a difference for the random value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently otherwise the random engine can be different on different platforms which I observed in #2625 with macos
at the same time I hardcoded the type for the
std::uniform_int_distribution. apparently this can also make a difference for the random value