Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor MaterialInteractor #2691

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 17, 2023

Aimed to improve consistency and split surface and volume interactions into two logical parts

pulled out of #2603

@andiwand andiwand added this to the next milestone Nov 17, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (eae867a) 49.56% compared to head (c18a62d) 49.56%.
Report is 1 commits behind head on main.

❗ Current head c18a62d differs from pull request most recent head 2f95f4b. Consider uploading reports for the commit 2f95f4b to get more accurate results

Files Patch % Lines
...ore/include/Acts/Propagator/MaterialInteractor.hpp 47.16% 10 Missing and 18 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
- Coverage   49.56%   49.56%   -0.01%     
==========================================
  Files         474      474              
  Lines       26928    26930       +2     
  Branches    12422    12423       +1     
==========================================
  Hits        13348    13348              
+ Misses       4751     4748       -3     
- Partials     8829     8834       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

paulgessinger
paulgessinger previously approved these changes Nov 17, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing substantial from my side. Seems like a good idea.

Core/include/Acts/Propagator/MaterialInteractor.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/MaterialInteractor.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/MaterialInteractor.hpp Outdated Show resolved Hide resolved
paulgessinger
paulgessinger previously approved these changes Nov 20, 2023
Copy link
Contributor

kodiakhq bot commented Nov 20, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot merged commit 825db48 into acts-project:main Nov 20, 2023
52 checks passed
@andiwand andiwand deleted the refactor-material-interactor branch November 20, 2023 14:49
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants