Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use seeding performance in score for Optuna and Orion automatic tuning #2662

Merged
merged 10 commits into from
Feb 5, 2024

Conversation

LuisFelipeCoelho
Copy link
Member

This makes it possible to use seeding performance in in score for automatic tuning instead of only ckf performance

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4f5a41) 48.99% compared to head (3a77541) 48.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2662   +/-   ##
=======================================
  Coverage   48.99%   48.99%           
=======================================
  Files         496      496           
  Lines       28938    28938           
  Branches    13704    13704           
=======================================
  Hits        14179    14179           
  Misses       4881     4881           
  Partials     9878     9878           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review November 20, 2023 08:09
Examples/Scripts/Optimization/Optuna_tuning.py Outdated Show resolved Hide resolved
Examples/Scripts/Optimization/Optuna_tuning.py Outdated Show resolved Hide resolved
Examples/Scripts/Optimization/Optuna_tuning.py Outdated Show resolved Hide resolved
Examples/Scripts/Optimization/Optuna_tuning.py Outdated Show resolved Hide resolved
Examples/Scripts/Optimization/Orion_tuning.py Outdated Show resolved Hide resolved
@paulgessinger paulgessinger added this to the next milestone Dec 6, 2023
@github-actions github-actions bot added the Stale label Jan 5, 2024
@LuisFelipeCoelho
Copy link
Member Author

I finally have addressed Felix comments. I think this is also good to go. @paulgessinger

@andiwand andiwand removed the Stale label Feb 5, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit 3a9c0bf into acts-project:main Feb 5, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Feb 5, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
… tuning (acts-project#2662)

This makes it possible to use seeding performance in in score for automatic tuning instead of only ckf performance
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
… tuning (acts-project#2662)

This makes it possible to use seeding performance in in score for automatic tuning instead of only ckf performance
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
… tuning (acts-project#2662)

This makes it possible to use seeding performance in in score for automatic tuning instead of only ckf performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants