feat: writeFloat for seeding performance in SeedingPerformanceWriter.cpp

[LuisFelipeCoelho]

Store (floats) total efficiency, fake rate, duplicate rate and purity in output root file as it is done with ckf performance writer.
This is useful for using the seeding parameters in optuna automatic tuning.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b2fd7d) 48.94% compared to head (6b4f578) 48.99%.
Report is 4 commits behind head on main.

❗ Current head 6b4f578 differs from pull request most recent head 941aff0. Consider uploading reports for the commit 941aff0 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
+ Coverage   48.94%   48.99%   +0.05%     
==========================================
  Files         496      492       -4     
  Lines       28913    28527     -386     
  Branches    13710    13485     -225     
==========================================
- Hits        14151    13978     -173     
+ Misses       4878     4814      -64     
+ Partials     9884     9735     -149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 941aff0

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

Invalidated by push of 6169fbf

[paulgessinger]

• Do we understand why the physmon outputs change? This should not be affected by some extra variables being written to the output files.
• The formatting seems to need a fix
• This PR picked up conflicts.
• The vector<float> output breaks uproot reading, and therefore unfortunately breaks the root file hash comparison. Not sure what the best fix for this is. It might be possible to skip these fields when calculating the hashes, but not entirely sure.

@LuisFelipeCoelho can you look into these points?

discovered CI issues

[LuisFelipeCoelho]

@paulgessinger if I revert it back to TVectorF it seems to work

[AJPfleger]

Maybe the uproot problem is solved with the new version? We could try again after #2770

[LuisFelipeCoelho]

I think this is good to go. @paulgessinger

[andiwand]

lgtm

[acts-project-service]

✅ Athena integration test results [c4f5a41]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟡	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco