refactor: Remove target estimation from navigator

[andiwand]

This is very unintuitive and might result in unwanted behavior

[codecov]

Codecov Report

Merging #2598 (0b81d07) into main (c3aa32f) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head 0b81d07 differs from pull request most recent head 8270e7d. Consider uploading reports for the commit 8270e7d to get more accurate results

@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
- Coverage   49.53%   49.51%   -0.02%     
==========================================
  Files         472      472              
  Lines       26732    26684      -48     
  Branches    12321    12291      -30     
==========================================
- Hits        13241    13212      -29     
- Misses       4753     4759       +6     
+ Partials     8738     8713      -25     

Files	Coverage Δ
Core/include/Acts/Propagator/Navigator.hpp	56.64% <100.00%> (-0.45%)	⬇️
Core/src/Geometry/TrackingVolume.cpp	47.49% <0.00%> (-0.16%)	⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 8270e7d

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

And the idea is to have this functionality fully contained in the surface aborter?

[andiwand]

And the idea is to have this functionality fully contained in the surface aborter?

the code I remove here is trying to estimate the target layer and volume based on an intersection with the target surface. this is done several times during navigation since this estimate could change.

I do not think that is it necessary to estimate those and if the user wants to decrease navigation candidates the target layer or volume should be provided directly

[andiwand]

this is addressed in #2625