Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typos and and grammar missed by the CI #2517

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

AJPfleger
Copy link
Contributor

Just random things I collected over the last months while reading some code.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2517 (ab6374a) into main (d8c447c) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head ab6374a differs from pull request most recent head 152827b. Consider uploading reports for the commit 152827b to get more accurate results

@@           Coverage Diff           @@
##             main    #2517   +/-   ##
=======================================
  Coverage   49.77%   49.77%           
=======================================
  Files         466      466           
  Lines       26310    26310           
  Branches    12093    12093           
=======================================
  Hits        13095    13095           
  Misses       4616     4616           
  Partials     8599     8599           
Files Coverage Δ
...ore/include/Acts/Clusterization/Clusterization.hpp 100.00% <ø> (ø)
...ore/include/Acts/Digitization/DigitizationCell.hpp 100.00% <ø> (ø)
Core/include/Acts/EventData/Measurement.hpp 80.00% <ø> (ø)
Core/include/Acts/EventData/TrackProxy.hpp 77.90% <ø> (ø)
...re/include/Acts/Geometry/CylinderVolumeBuilder.hpp 25.52% <ø> (ø)
...lude/Acts/Geometry/ITrackingVolumeArrayCreator.hpp 100.00% <ø> (ø)
Core/include/Acts/Geometry/LayerCreator.hpp 100.00% <ø> (ø)
Core/include/Acts/Navigation/DetectorNavigator.hpp 51.09% <ø> (ø)
Core/include/Acts/Propagator/ActionList.hpp 100.00% <ø> (ø)
Core/include/Acts/Propagator/AtlasStepper.hpp 72.15% <ø> (ø)
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger added this to the next milestone Oct 9, 2023
paulgessinger
paulgessinger previously approved these changes Oct 9, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Copy link
Contributor

@felix-russo felix-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that Paul already reviewed but I was halfway through so I decided to leave these minor comments

@kodiakhq kodiakhq bot merged commit 658faae into acts-project:main Oct 10, 2023
54 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 10, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Oct 10, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.2.0 Oct 13, 2023
@AJPfleger AJPfleger deleted the typos branch October 21, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants