Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Python bindings for Geant4 manager and handle #2500

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Oct 3, 2023

This enables us to inspect the current handle of Geant4 and therefore adjust the log level from python which is useful while debugging.

@andiwand andiwand added this to the next milestone Oct 3, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2500 (e8a62c9) into main (a3013a0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files         466      466           
  Lines       26262    26262           
  Branches    12063    12063           
=======================================
  Hits        13076    13076           
  Misses       4613     4613           
  Partials     8573     8573           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

felix-russo
felix-russo previously approved these changes Oct 3, 2023
Copy link
Contributor

@felix-russo felix-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question for my personal understanding

Examples/Python/src/Geant4Component.cpp Outdated Show resolved Hide resolved
@acts-policybot acts-policybot bot dismissed felix-russo’s stale review October 3, 2023 11:08

Invalidated by push of 90a18d9

@kodiakhq kodiakhq bot merged commit f2c21c2 into acts-project:main Oct 5, 2023
59 checks passed
@github-actions github-actions bot removed the automerge label Oct 5, 2023
@andiwand andiwand deleted the python-binding-g4-manager+handle branch October 5, 2023 11:49
@paulgessinger paulgessinger modified the milestones: next, v30.1.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants