-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Python bindings for Geant4 manager and handle #2500
Merged
kodiakhq
merged 6 commits into
acts-project:main
from
andiwand:python-binding-g4-manager+handle
Oct 5, 2023
Merged
feat: Python bindings for Geant4 manager and handle #2500
kodiakhq
merged 6 commits into
acts-project:main
from
andiwand:python-binding-g4-manager+handle
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2500 +/- ##
=======================================
Coverage 49.79% 49.79%
=======================================
Files 466 466
Lines 26262 26262
Branches 12063 12063
=======================================
Hits 13076 13076
Misses 4613 4613
Partials 8573 8573 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
felix-russo
previously approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question for my personal understanding
acts-policybot
bot
dismissed
felix-russo’s stale review
October 3, 2023 11:08
Invalidated by push of 90a18d9
paulgessinger
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to inspect the current handle of Geant4 and therefore adjust the log level from python which is useful while debugging.