-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Align initial track param covariance #2491
refactor: Align initial track param covariance #2491
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2491 +/- ##
==========================================
- Coverage 49.82% 49.81% -0.02%
==========================================
Files 466 466
Lines 26247 26248 +1
Branches 12050 12051 +1
==========================================
- Hits 13078 13075 -3
- Misses 4603 4606 +3
- Partials 8566 8567 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Either we restore the previous defaults, or we update the references.
Currently the initial track param covariance will depend on the chosen seeder. Truth smeared will use the configured sigmas to cook up a cov while to other seeder take a directly configured one.
Here I align the truth smeared to the others which also allows to experiment with the covariance separately from the smearing.