Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Align initial track param covariance #2491

Merged
merged 7 commits into from
Sep 29, 2023

Conversation

andiwand
Copy link
Contributor

Currently the initial track param covariance will depend on the chosen seeder. Truth smeared will use the configured sigmas to cook up a cov while to other seeder take a directly configured one.

Here I align the truth smeared to the others which also allows to experiment with the covariance separately from the smearing.

@andiwand andiwand added this to the next milestone Sep 28, 2023
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2491 (27fc978) into main (4515f2c) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
- Coverage   49.82%   49.81%   -0.02%     
==========================================
  Files         466      466              
  Lines       26247    26248       +1     
  Branches    12050    12051       +1     
==========================================
- Hits        13078    13075       -3     
- Misses       4603     4606       +3     
- Partials     8566     8567       +1     
Files Coverage Δ
.../include/Acts/TrackFinding/MeasurementSelector.hpp 32.81% <26.66%> (-5.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Either we restore the previous defaults, or we update the references.

@kodiakhq kodiakhq bot merged commit 20fa776 into acts-project:main Sep 29, 2023
57 checks passed
@andiwand andiwand deleted the align-initial-track-param-cov branch September 29, 2023 21:49
@paulgessinger paulgessinger modified the milestones: next, v30.1.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants