Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove obsolete assignments due to calculateTrackQuantities() #2487

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

AJPfleger
Copy link
Contributor

With calculateTrackQuantities(track); we reset track.nMeasurements() and track.nHoles(), no need to set them before.

@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2487 (e4d2bce) into main (ffc9e12) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2487   +/-   ##
=======================================
  Coverage   49.84%   49.85%           
=======================================
  Files         466      466           
  Lines       26250    26248    -2     
  Branches    12034    12032    -2     
=======================================
  Hits        13085    13085           
  Misses       4615     4615           
+ Partials     8550     8548    -2     
Files Coverage Δ
Core/include/Acts/TrackFitting/KalmanFitter.hpp 43.13% <ø> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger added this to the next milestone Sep 28, 2023
@kodiakhq kodiakhq bot merged commit 753dbec into acts-project:main Sep 28, 2023
58 checks passed
@AJPfleger AJPfleger deleted the kf-small-fix branch September 29, 2023 14:41
AJPfleger added a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
…s()` (acts-project#2487)

With `calculateTrackQuantities(track);` we reset `track.nMeasurements()` and `track.nHoles()`, no need to set them before.
@paulgessinger paulgessinger modified the milestones: next, v30.1.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants