-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make CKF branching configurable from python #2486
Merged
kodiakhq
merged 6 commits into
acts-project:main
from
andiwand:feature-examples-make-ckf-branching-configurable
Sep 29, 2023
Merged
feat: Make CKF branching configurable from python #2486
kodiakhq
merged 6 commits into
acts-project:main
from
andiwand:feature-examples-make-ckf-branching-configurable
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2486 +/- ##
=======================================
Coverage 49.81% 49.81%
=======================================
Files 466 466
Lines 26248 26248
Branches 12051 12051
=======================================
Hits 13075 13075
Misses 4606 4606
Partials 8567 8567 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
commented
Sep 29, 2023
benjaminhuth
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
andiwand
deleted the
feature-examples-make-ckf-branching-configurable
branch
September 29, 2023 21:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we hardcode the branching config in python which makes it hard to find the default and unchangeable for the user. With this PR I add a struct
TrackFindingConfig
which defines the branching params and lower the defaults in hope to spare some resources with ttbar events.