Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make CKF branching configurable from python #2486

Conversation

andiwand
Copy link
Contributor

Currently we hardcode the branching config in python which makes it hard to find the default and unchangeable for the user. With this PR I add a struct TrackFindingConfig which defines the branching params and lower the defaults in hope to spare some resources with ttbar events.

@andiwand andiwand added this to the next milestone Sep 27, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2486 (0d299da) into main (20fa776) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2486   +/-   ##
=======================================
  Coverage   49.81%   49.81%           
=======================================
  Files         466      466           
  Lines       26248    26248           
  Branches    12051    12051           
=======================================
  Hits        13075    13075           
  Misses       4606     4606           
  Partials     8567     8567           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit 363d111 into acts-project:main Sep 29, 2023
57 checks passed
@andiwand andiwand deleted the feature-examples-make-ckf-branching-configurable branch September 29, 2023 21:49
@paulgessinger paulgessinger modified the milestones: next, v30.1.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants