-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: volume agnostic material interaction #2465
Merged
kodiakhq
merged 8 commits into
acts-project:main
from
asalzburger:feat-volume-agnostic-material-interaction
Sep 20, 2023
Merged
feat: volume agnostic material interaction #2465
kodiakhq
merged 8 commits into
acts-project:main
from
asalzburger:feat-volume-agnostic-material-interaction
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
labels
Sep 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
Coverage 49.81% 49.82%
=======================================
Files 465 466 +1
Lines 26135 26139 +4
Branches 11982 11983 +1
=======================================
+ Hits 13020 13023 +3
Misses 4615 4615
- Partials 8500 8501 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ! I just have one question and after I can approve.
Corentin-Allaire
approved these changes
Sep 20, 2023
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Sep 20, 2023
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
This PR introduces an `InteractionVolum` helper class that allows to switch between `TrackingVolume` and `DetectorVolume` and through that makes the material interaction recording struct quasi volume agnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an
InteractionVolum
helper class that allows to switch betweenTrackingVolume
andDetectorVolume
and through that makes the material interaction recording struct quasi volume agnostic.