Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract impact parameters and their covariance matrix #2464

Merged
merged 8 commits into from
Sep 26, 2023
Merged

feat: extract impact parameters and their covariance matrix #2464

merged 8 commits into from
Sep 26, 2023

Conversation

felix-russo
Copy link
Contributor

@felix-russo felix-russo commented Sep 19, 2023 •
edited
Loading

Allow extraction of the

  • impact parameters (i.e., d0, z0, and, optionally, t) and
  • the corresponding covariance matrix

from GenericBoundTrackParameters

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #2464 (ca41ed6) into main (2b922b0) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #2464      +/-   ##
==========================================
- Coverage   49.86%   49.85%   -0.01%     
==========================================
  Files         466      466              
  Lines       26249    26253       +4     
  Branches    12032    12034       +2     
==========================================
+ Hits        13088    13089       +1     
- Misses       4614     4615       +1     
- Partials     8547     8549       +2
Files Coverage Δ
...nclude/Acts/Vertexing/AdaptiveGridTrackDensity.ipp 61.15% <0.00%> (ø)
...nclude/Acts/Vertexing/GaussianGridTrackDensity.ipp 66.40% <0.00%> (ø)
...ude/Acts/EventData/GenericBoundTrackParameters.hpp 67.56% <25.00%> (-2.44%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

📊: Physics performance monitoring for ca41ed6

Full contents

physmon summary

@felix-russo felix-russo changed the title feat: extract impact parameter covariance matrix feat: extract impact parameter and their covariance matrix Sep 20, 2023
@felix-russo felix-russo changed the title feat: extract impact parameter and their covariance matrix feat: extract impact parameters and their covariance matrix Sep 20, 2023
@felix-russo felix-russo marked this pull request as ready for review September 21, 2023 07:19
paulgessinger
paulgessinger requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea! I have some comments.
Mainly it's choices, but I think you're returning an invalid dangling referene, which is unsafe.

Core/include/Acts/EventData/GenericBoundTrackParameters.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/GenericBoundTrackParameters.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/GenericBoundTrackParameters.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/GenericBoundTrackParameters.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/GenericBoundTrackParameters.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/GenericBoundTrackParameters.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Vertexing/AdaptiveGridTrackDensity.ipp Outdated Show resolved Hide resolved
@paulgessinger paulgessinger added this to the next milestone Sep 26, 2023
@kodiakhq kodiakhq bot merged commit a23fe6d into acts-project:main Sep 26, 2023
56 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Sep 26, 2023 •
edited
Loading

✅ Athena integration test results

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 26, 2023
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
@felix-russo @AJPfleger
feat: extract impact parameters and their covariance matrix (acts-pro…
c2260f0 
…ject#2464)

Allow extraction of the 

- impact parameters (i.e., `d0`, `z0`, and, optionally, `t`) and
- the corresponding covariance matrix

from `GenericBoundTrackParameters`
@felix-russo felix-russo deleted the submatrix-ipe branch October 3, 2023 11:38
@paulgessinger paulgessinger modified the milestones: next, v30.1.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Event Data Model Fails Athena tests This PR causes a failure in the Athena tests Vertexing
Projects
None yet
Milestone
v30.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@felix-russo @acts-project-service @paulgessinger