Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Reduce WARNING verbosity in 2 cases #2458

Merged

Conversation

benjaminhuth
Copy link
Member

Replaces in 2 cases a potentially large amount of WARNING output with DEBUG output and a single WARNING message with a hint to the debug output.

@benjaminhuth benjaminhuth added this to the next milestone Sep 18, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting labels Sep 18, 2023
@benjaminhuth benjaminhuth changed the title refacor: Reduce WARNING verbosity in 2 cases refactor: Reduce WARNING verbosity in 2 cases Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2458 (dcc1181) into main (19662db) will increase coverage by 0.00%.
The diff coverage is 37.50%.

@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   49.78%   49.78%           
=======================================
  Files         461      461           
  Lines       26009    26015    +6     
  Branches    11919    11921    +2     
=======================================
+ Hits        12949    12952    +3     
- Misses       4608     4610    +2     
- Partials     8452     8453    +1     
Files Changed Coverage Δ
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 45.88% <25.00%> (+0.02%) ⬆️
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 44.73% <50.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andiwand
andiwand previously approved these changes Sep 18, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Sep 18, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot merged commit d62a42f into acts-project:main Sep 19, 2023
58 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 19, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.0.0 Sep 20, 2023
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
Replaces in 2 cases a potentially large amount of WARNING output with DEBUG output and a single WARNING message with a hint to the debug output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants