-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Reduce WARNING verbosity in 2 cases #2458
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
benjaminhuth:refactor/reduce-warning-verbosity
Sep 19, 2023
Merged
refactor: Reduce WARNING verbosity in 2 cases #2458
kodiakhq
merged 3 commits into
acts-project:main
from
benjaminhuth:refactor/reduce-warning-verbosity
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Fitting
labels
Sep 18, 2023
benjaminhuth
changed the title
refacor: Reduce WARNING verbosity in 2 cases
refactor: Reduce WARNING verbosity in 2 cases
Sep 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #2458 +/- ##
=======================================
Coverage 49.78% 49.78%
=======================================
Files 461 461
Lines 26009 26015 +6
Branches 11919 11921 +2
=======================================
+ Hits 12949 12952 +3
- Misses 4608 4610 +2
- Partials 8452 8453 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
previously approved these changes
Sep 18, 2023
This PR currently has a merge conflict. Please resolve this and then re-add the |
andiwand
approved these changes
Sep 19, 2023
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Sep 19, 2023
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
Replaces in 2 cases a potentially large amount of WARNING output with DEBUG output and a single WARNING message with a hint to the debug output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Fitting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces in 2 cases a potentially large amount of WARNING output with DEBUG output and a single WARNING message with a hint to the debug output.