refactor: Optional curvilinear state in Propagator

[paulgessinger]

So far, without a target surface, the propagator unconditionally produces curvilinear parameters, and allocates a plane surface for this. This adds an argument, which if set to false tells the Propagator not to do that. In particular, we don't use this curvilinear state at all in the CKF and KF (I'm not sure about the GSF).

[benjaminhuth]

In particular, we don't use this curvilinear state at all in the CKF and KF (I'm not sure about the GSF).

It isn't used in the GSF either. Rather, the requirement to provide this functionality is a bit annoying (but it should be there I guess)

[codecov]

Codecov Report

Merging #2444 (d358bbc) into main (9e20cea) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 56.52%.

@@            Coverage Diff             @@
##             main    #2444      +/-   ##
==========================================
- Coverage   49.71%   49.70%   -0.01%     
==========================================
  Files         461      461              
  Lines       25989    25990       +1     
  Branches    11934    11935       +1     
==========================================
- Hits        12921    12919       -2     
- Misses       4600     4602       +2     
- Partials     8468     8469       +1     

Files Changed	Coverage Δ
Core/include/Acts/Propagator/Propagator.hpp	93.33% <ø> (ø)
Core/include/Acts/Surfaces/CylinderSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/DiscSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/PlaneSurface.hpp	100.00% <ø> (ø)
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp	43.91% <ø> (ø)
Core/include/Acts/Propagator/Propagator.ipp	43.58% <42.85%> (+0.73%)	⬆️
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp	39.39% <50.00%> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp	43.22% <50.00%> (ø)
Core/src/Surfaces/CylinderSurface.cpp	37.98% <50.00%> (ø)
Core/src/Surfaces/DiscSurface.cpp	33.33% <66.66%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for d358bbc

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[benjaminhuth]

Let's get it in!