feat: Support also 1d-measurements in GX2F #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
reviewed
Sep 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 49.78% 49.78%
=======================================
Files 461 461
Lines 26018 26023 +5
Branches 11922 11921 -1
=======================================
+ Hits 12952 12955 +3
- Misses 4613 4616 +3
+ Partials 8453 8452 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asalzburger
approved these changes
Sep 19, 2023
|
Adding auto merge since this one now built several times fine. |
AJPfleger
added a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
This generalises the Global Chi Square Fitter (GX2F). Now it can fit 1-dimensional measurements (`loc0`, `loc1`), 2-dimensional measurements (`loc01`), and a combination of these. The generalisation for n-dimensional measurements should only need the implementation of the `visit_measurement` function, but also requires us to expand the testing framework, so we can generate 3-plus-dimensional measurements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalises the Global Chi Square Fitter (GX2F). Now it can fit 1-dimensional measurements (
loc0,loc1), 2-dimensional measurements (loc01), and a combination of these.The generalisation for n-dimensional measurements should only need the implementation of the
visit_measurementfunction, but also requires us to expand the testing framework, so we can generate 3-plus-dimensional measurements.