-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Perform the Greedy Solver after the ML Solver #2434
feat: Perform the Greedy Solver after the ML Solver #2434
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2434 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 455 455
Lines 25840 25840
Branches 11861 11861
=======================================
Hits 12843 12843
Misses 4592 4592
Partials 8405 8405 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
this requires some reference file changes |
Ah yes, I forgot about that. I am on it |
This PR modify the odd full chain to call the Greedy solver on the output of the MLSolver. This has been tested on ttbar mu=200 PU and removes almost all the remaining duplicates at almost no cost in term of efficiency and speed.
This PR also change the full chain default back to mu=200 and the seeding range to match the ODD eta range.