Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Perform the Greedy Solver after the ML Solver #2434

Merged

Conversation

Corentin-Allaire
Copy link
Contributor

This PR modify the odd full chain to call the Greedy solver on the output of the MLSolver. This has been tested on ttbar mu=200 PU and removes almost all the remaining duplicates at almost no cost in term of efficiency and speed.

This PR also change the full chain default back to mu=200 and the seeding range to match the ODD eta range.

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Seeding labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2434 (6f21f47) into main (03d2e5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2434   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         455      455           
  Lines       25840    25840           
  Branches    11861    11861           
=======================================
  Hits        12843    12843           
  Misses       4592     4592           
  Partials     8405     8405           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

andiwand
andiwand previously approved these changes Sep 8, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andiwand andiwand added this to the next milestone Sep 8, 2023
@andiwand andiwand removed the automerge label Sep 8, 2023
@andiwand
Copy link
Contributor

andiwand commented Sep 8, 2023

this requires some reference file changes

@Corentin-Allaire
Copy link
Contributor Author

this requires some reference file changes

Ah yes, I forgot about that. I am on it

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Sep 8, 2023
@kodiakhq kodiakhq bot merged commit 109fb7d into acts-project:main Sep 8, 2023
57 checks passed
@github-actions github-actions bot removed the automerge label Sep 8, 2023
@acts-project-service
Copy link
Collaborator

acts-project-service commented Sep 8, 2023

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 8, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.2.0 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants