Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve python error messages #2415

Merged

Conversation

benjaminhuth
Copy link
Member

Sometimes, the setattr in our special python constructor fails, and its not so easy to find out why. This should help by printing the key and the value that did not work together.

@benjaminhuth benjaminhuth added this to the next milestone Sep 1, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2415 (ac0f3b0) into main (3e77d7d) will increase coverage by 0.09%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
+ Coverage   49.59%   49.69%   +0.09%     
==========================================
  Files         453      454       +1     
  Lines       25694    25809     +115     
  Branches    11808    11852      +44     
==========================================
+ Hits        12744    12825      +81     
- Misses       4572     4581       +9     
- Partials     8378     8403      +25     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@paulgessinger paulgessinger merged commit 6974f92 into acts-project:main Sep 4, 2023
55 of 56 checks passed
@github-actions github-actions bot removed the automerge label Sep 4, 2023
@benjaminhuth benjaminhuth deleted the refactor/improve-python-error branch September 4, 2023 07:23
@paulgessinger paulgessinger modified the milestones: next, v29.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants