Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: LineSurface back to col(2) for local z axis #2 #2382

Merged
merged 2 commits into from
Aug 18, 2023
Merged

perf: LineSurface back to col(2) for local z axis #2 #2382

merged 2 commits into from
Aug 18, 2023

Conversation

andiwand
Copy link
Contributor

second try after #2369

Back to col(2) as it seems more optimal in terms of resources

@andiwand andiwand modified the milestones: next, v29.0.0 Aug 18, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Merging #2382 (14f72d0) into main (800c484) will increase coverage by 0.00%.
The diff coverage is 12.50%.

@@           Coverage Diff           @@
##             main    #2382   +/-   ##
=======================================
  Coverage   49.58%   49.58%           
=======================================
  Files         453      453           
  Lines       25509    25511    +2     
  Branches    11703    11704    +1     
=======================================
+ Hits        12648    12649    +1     
  Misses       4580     4580           
- Partials     8281     8282    +1
Files Changed Coverage Δ
Core/include/Acts/Surfaces/LineSurface.hpp 100.00% <ø> (ø)
Core/src/Surfaces/LineSurface.cpp 35.57% <12.50%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 18, 2023 •
edited
Loading

📊: Physics performance monitoring for 14f72d0

Full contents

physmon summary

paulgessinger
paulgessinger approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@kodiakhq kodiakhq bot merged commit 975b104 into acts-project:main Aug 18, 2023
54 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Aug 18, 2023
@andiwand andiwand deleted the opt-line-surface-z-axis branch August 18, 2023 19:22
@paulgessinger
Copy link
Member

Build failure unrelated, but this did in fact change the Athena outputs.

@paulgessinger paulgessinger added Fails Athena tests This PR causes a failure in the Athena tests and removed Breaks Athena build This PR breaks the Athena build labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v29.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @acts-project-service @paulgessinger