Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make SourceLink SBO size configurable via CMake #2357

Merged

Conversation

paulgessinger
Copy link
Member

This PR allows customizing the SBO size that SourceLink uses. We default to a sort of generous 16 bytes, and clients might want to reduce this.

@paulgessinger paulgessinger added this to the next milestone Aug 8, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Documentation Affects the documentation Event Data Model labels Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2357 (b63e2b7) into main (0f745ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2357   +/-   ##
=======================================
  Coverage   49.63%   49.63%           
=======================================
  Files         453      453           
  Lines       25530    25530           
  Branches    11705    11705           
=======================================
  Hits        12672    12672           
  Misses       4579     4579           
  Partials     8279     8279           
Files Changed Coverage Δ
Core/include/Acts/EventData/SourceLink.hpp 87.50% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question - otherwise good to go IMO

Core/include/Acts/EventData/SourceLink.hpp Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 7ae364d into acts-project:main Aug 14, 2023
53 checks passed
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants