-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make SourceLink SBO size configurable via CMake #2357
Merged
kodiakhq
merged 2 commits into
acts-project:main
from
paulgessinger:refactor/sourcelink-sbo-customize
Aug 14, 2023
Merged
feat: Make SourceLink SBO size configurable via CMake #2357
kodiakhq
merged 2 commits into
acts-project:main
from
paulgessinger:refactor/sourcelink-sbo-customize
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Documentation
Affects the documentation
Event Data Model
labels
Aug 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
Coverage 49.63% 49.63%
=======================================
Files 453 453
Lines 25530 25530
Branches 11705 11705
=======================================
Hits 12672 12672
Misses 4579 4579
Partials 8279 8279
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for b63e2b7physmon summary
|
andiwand
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question - otherwise good to go IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Documentation
Affects the documentation
Event Data Model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows customizing the SBO size that SourceLink uses. We default to a sort of generous 16 bytes, and clients might want to reduce this.