-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Add CalibrationContext to calibrator signature #2354
refactor!: Add CalibrationContext to calibrator signature #2354
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2354 +/- ##
==========================================
+ Coverage 49.52% 49.53% +0.01%
==========================================
Files 453 453
Lines 25686 25692 +6
Branches 11818 11818
==========================================
+ Hits 12721 12727 +6
Misses 4583 4583
Partials 8382 8382
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me - left two minor comments
This is currently unused, but should allow the calibrator to become conditions-aware.
fe9bc3b
to
c57ef3f
Compare
Rebased and updated. Should hopefully clear the CI now. |
Co-authored-by: Andreas Stefl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it in!
Had one more conflict from #2356 which should be gone now. |
This is currently unused by the calibrators, but should allow the calibrator to become
conditions-aware.
Blocked by:
Closes #2274