-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Track parameter estimation might give inf time #2353
Merged
kodiakhq
merged 2 commits into
acts-project:main
from
paulgessinger:fix/track-par-estimat-divbyzero
Aug 8, 2023
Merged
fix: Track parameter estimation might give inf time #2353
kodiakhq
merged 2 commits into
acts-project:main
from
paulgessinger:fix/track-par-estimat-divbyzero
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This popped up as a persistent test failure on macOS, but apparently not anywhere else. I think if we have estimated parameters here without a z component, the time calculated is inf. There's already a fallback caldulation in case the path length along z is 0, which I think we can reuse.
Codecov Report
@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 49.64% 49.64% -0.01%
==========================================
Files 453 453
Lines 25538 25538
Branches 11708 11708
==========================================
- Hits 12679 12678 -1
Misses 4578 4578
- Partials 8281 8282 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 18e686aphysmon summary
|
felix-russo
reviewed
Aug 8, 2023
felix-russo
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This popped up as a persistent test failure on macOS, but apparently not anywhere else. I think if we have estimated parameters here without a z component, the time calculated is inf. There's already a fallback caldulation in case the path length along z is 0, which I think we can reuse.