Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Track parameter estimation might give inf time #2353

Merged

Conversation

paulgessinger
Copy link
Member

This popped up as a persistent test failure on macOS, but apparently not anywhere else. I think if we have estimated parameters here without a z component, the time calculated is inf. There's already a fallback caldulation in case the path length along z is 0, which I think we can reuse.

This popped up as a persistent test failure on macOS, but apparently not
anywhere else. I think if we have estimated parameters here without a z
component, the time calculated is inf. There's already a fallback
caldulation in case the path length along z is 0, which I think we can
reuse.
@paulgessinger paulgessinger added this to the next milestone Aug 4, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Seeding labels Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2353 (18e686a) into main (f651d07) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   49.64%   49.64%   -0.01%     
==========================================
  Files         453      453              
  Lines       25538    25538              
  Branches    11708    11708              
==========================================
- Hits        12679    12678       -1     
  Misses       4578     4578              
- Partials     8281     8282       +1     
Files Changed Coverage Δ
...clude/Acts/Seeding/EstimateTrackParamsFromSeed.hpp 49.20% <0.00%> (-0.80%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 10b40b7 into acts-project:main Aug 8, 2023
53 checks passed
@github-actions github-actions bot removed the automerge label Aug 8, 2023
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants