Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: FPE masking updates & improvements #2349

Merged
merged 20 commits into from
Aug 29, 2023

Conversation

paulgessinger
Copy link
Member

This PR does three things:

  1. change fpe mask comment format issue:1234 -> #1234
  2. Line ranges now possible in FPE masking
    This works both with the explicit mask lists / yaml inputs, but also with markers like
// MARK: fpeMaskBegin(FLTINV, 1, issue:2284)
thisMakesAnFLTINV();
// MARK: fpeMaskEnd(FLTINV)
  1. Improved FPE mask reporting in interactive running: When launching the Sequencer, the masks will now be checked if their file paths are valid, and it will show the masked pieces of code.

This works both with the explicit mask lists / yaml inputs, but also
with markers like

```cpp
// MARK: fpeMaskBegin(FLTINV, 1, issue:2284)
thisMakesAnFLTINV();
// MARK: fpeMaskEnd(FLTINV)
```
@paulgessinger paulgessinger added this to the next milestone Aug 4, 2023
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module labels Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2349 (b926c2e) into main (d72def3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2349   +/-   ##
=======================================
  Coverage   49.59%   49.59%           
=======================================
  Files         453      453           
  Lines       25694    25694           
  Branches    11808    11808           
=======================================
  Hits        12744    12744           
  Misses       4572     4572           
  Partials     8378     8378           
Files Changed Coverage Δ
...nclude/Acts/Utilities/GaussianMixtureReduction.hpp 38.46% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module labels Aug 4, 2023
niermann999
niermann999 previously approved these changes Aug 10, 2023
Examples/Python/python/acts/examples/__init__.py Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Aug 15, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few suggestions but already looks good as is. feel free to automerge

@kodiakhq kodiakhq bot merged commit e529c52 into acts-project:main Aug 29, 2023
54 checks passed
@paulgessinger paulgessinger modified the milestones: next, v29.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants