-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: FPE masking updates & improvements #2349
Conversation
This works both with the explicit mask lists / yaml inputs, but also with markers like ```cpp // MARK: fpeMaskBegin(FLTINV, 1, issue:2284) thisMakesAnFLTINV(); // MARK: fpeMaskEnd(FLTINV) ```
Codecov Report
@@ Coverage Diff @@
## main #2349 +/- ##
=======================================
Coverage 49.59% 49.59%
=======================================
Files 453 453
Lines 25694 25694
Branches 11808 11808
=======================================
Hits 12744 12744
Misses 4572 4572
Partials 8378 8378
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Invalidated by push of fa9d9f8
Examples/Framework/include/ActsExamples/Framework/Sequencer.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few suggestions but already looks good as is. feel free to automerge
This PR does three things:
issue:1234
->#1234
This works both with the explicit mask lists / yaml inputs, but also with markers like