-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow CKF smoothing without a target surface #2317
fix: Allow CKF smoothing without a target surface #2317
Conversation
📊 Physics performance monitoring for d0740bbSummary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #2317 +/- ##
=======================================
Coverage 49.47% 49.47%
=======================================
Files 451 451
Lines 25482 25484 +2
Branches 11720 11720
=======================================
+ Hits 12608 12609 +1
Misses 4582 4582
- Partials 8292 8293 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty clear to me. Approving.
The current CKF implementation does not allow for smoothing without setting a target surface as this would result in a null pointer dereference. I try to fix that by handling the special case of not having a target surface.