Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow CKF smoothing without a target surface #2317

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

andiwand
Copy link
Contributor

The current CKF implementation does not allow for smoothing without setting a target surface as this would result in a null pointer dereference. I try to fix that by handling the special case of not having a target surface.

@andiwand andiwand added this to the next milestone Jul 25, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Jul 25, 2023
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

📊 Physics performance monitoring for d0740bb

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #2317 (d0740bb) into main (5252d07) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main    #2317   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files         451      451           
  Lines       25482    25484    +2     
  Branches    11720    11720           
=======================================
+ Hits        12608    12609    +1     
  Misses       4582     4582           
- Partials     8292     8293    +1     
Files Changed Coverage Δ
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.07% <25.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@noemina noemina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear to me. Approving.

@paulgessinger paulgessinger mentioned this pull request Jul 26, 2023
1 task
@kodiakhq kodiakhq bot merged commit 9cdf2fe into acts-project:main Jul 26, 2023
53 checks passed
@andiwand andiwand deleted the fix-ckf-smoothing-without-target branch July 26, 2023 15:53
@paulgessinger paulgessinger modified the milestones: next, v28.0.0 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants