Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add compiled version info #2313

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

paulgessinger
Copy link
Member

This should help us detect when we're running with a mismatched header/shared lib combo, like can happen in the hack-build in Athena.

This should help us detect when we're running with a mismatched
header/shared lib combo, like can happen in the hack-build in Athena.
@paulgessinger paulgessinger added this to the next milestone Jul 24, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Jul 24, 2023
Core/ActsVersion.hpp.in Outdated Show resolved Hide resolved
Core/ActsVersion.hpp.in Outdated Show resolved Hide resolved
@paulgessinger paulgessinger marked this pull request as draft July 24, 2023 12:35
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #2313 (7b430cf) into main (dbcba62) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2313      +/-   ##
==========================================
- Coverage   49.51%   49.47%   -0.04%     
==========================================
  Files         450      451       +1     
  Lines       25465    25482      +17     
  Branches    11718    11720       +2     
==========================================
  Hits        12608    12608              
- Misses       4565     4582      +17     
  Partials     8292     8292              
Files Changed Coverage Δ
Core/src/ActsVersion.cpp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

📊 Physics performance monitoring for 7b430cf

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger paulgessinger marked this pull request as ready for review July 25, 2023 08:06
andiwand
andiwand previously approved these changes Jul 25, 2023
Core/ActsVersion.hpp.in Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 21cb496 into acts-project:main Jul 25, 2023
1 check passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 25, 2023
@paulgessinger paulgessinger modified the milestones: next, v28.0.0 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants