feat: Multiwire builder #2275
Merged
feat: Multiwire builder #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2275 +/- ##
========================================
Coverage 49.70% 49.70%
========================================
Files 455 458 +3
Lines 25840 25946 +106
Branches 11860 11918 +58
========================================
+ Hits 12843 12896 +53
- Misses 4592 4595 +3
- Partials 8405 8455 +50
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dimitra97
force-pushed
the
multiwire-builder
branch
from
0884792
to
e956b01
Compare
github-actions
bot
removed
Component - Examples
dimitra97
force-pushed
the
multiwire-builder
branch
5 times, most recently
from
403e9bb
to
df37950
Compare
An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <[email protected]> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update fix LayerStructure builder fix fix Delete MuonChamber.gdml revert layer strucutre builder from upstream reslove conflict Multi Layer Builder cmake file Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <[email protected]> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Delete IndexedSurfacesNavigationTests.cpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update fix LayerStructure builder fix fix Delete MuonChamber.gdml revert layer strucutre builder from upstream cmake file Update MultiWireStructureBuilder.hpp Update MultiWireStructureBuilder.hpp Update MultiWireStructureBuilder.cpp Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <[email protected]> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Delete IndexedSurfacesNavigationTests.cpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update LayerStructure builder fix fix Delete MuonChamber.gdml revert gdml from upstream revert layer strucutre builder from upstream fix conflicts and some optimizations conflicts and format revert some files revert some files new updator fix license issue fix
dimitra97
force-pushed
the
multiwire-builder
branch
from
df37950
to
77d24d6
Compare
dimitra97
force-pushed
the
multiwire-builder
branch
from
9b67e74
to
4375676
Compare
dimitra97
force-pushed
the
multiwire-builder
branch
from
ae658f9
to
c85ff3e
Compare
dimitra97
force-pushed
the
multiwire-builder
branch
from
0e1566b
to
0ca0b9e
Compare
noemina
reviewed
Sep 6, 2023
dimitra97
force-pushed
the
multiwire-builder
branch
from
6681f42
to
e2155b1
Compare
noemina
previously approved these changes
Sep 8, 2023
dimitra97
force-pushed
the
multiwire-builder
branch
from
7e3190d
to
8fd61a7
Compare
dimitra97
force-pushed
the
multiwire-builder
branch
from
ae644af
to
b52fa0f
Compare
noemina
previously approved these changes
Sep 11, 2023
noemina
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the builder for a Multi Layer Wire Structure using an internal and external builder. It also introduces a multilayer updator for grid-based indexed surfaces that is used inside the inner builder and a unit test that checks the surface candidates collected along a projected path as shown in the attached pictures.
