-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Rename Single*TrackParameters
to Generic*TrackParameters
#2269
refactor!: Rename Single*TrackParameters
to Generic*TrackParameters
#2269
Conversation
not sure if we consider this one breaking as the typedefs did not change |
Codecov Report
@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
+ Coverage 49.47% 49.56% +0.08%
==========================================
Files 451 451
Lines 25484 25477 -7
Branches 11720 11700 -20
==========================================
+ Hits 12609 12628 +19
+ Misses 4582 4575 -7
+ Partials 8293 8274 -19
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 6d9627fSummary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
@andiwand The top-level typedefs don't change name or meaning, really. OTOH the other typenames do in fact change. I guess I'd lean towards calling it breaking. |
Single*TrackParameters
to Generic*TrackParameters
Single*TrackParameters
to Generic*TrackParameters
@paulgessinger should we hold this back until we have all the breaking changes ready for one release? if so, how should we flag that? blocked or should we create a milestone for that? |
We're ready to go for |
@benjaminhuth could you help review this? |
There are a bunch of conflicts @andiwand |
…etrackparam-to-generic
I am unhappy with the name
Single*TrackParameters
as it could refer to singly charged or single track. The track actually supports different kinds of charge hypothesis so I thoughtGeneric*TrackParameter
might fit better.I also merged
NeutralTrackParameters
intoTrackParameters
and removed the external template instantiation as it could be a performance hit because it disables inlining.Pulled these changes out of #2181