-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: qOverP
and absoluteMomentum
for Stepper interface
#2253
refactor: qOverP
and absoluteMomentum
for Stepper interface
#2253
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 449 449
Lines 25405 25408 +3
Branches 11724 11724
=======================================
+ Hits 12518 12521 +3
Misses 4554 4554
Partials 8333 8333
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
qOverP
and absoluteMomentum
for Stepper interfaceqOverP
and absoluteMomentum
for Stepper interface
qOverP
and absoluteMomentum
for Stepper interfaceqOverP
and absoluteMomentum
for Stepper interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine from my side.
📊 Physics performance monitoring for 04f2365Summary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
I guess this is also not really breaking if you don't use the Stepper directly? |
Yeah depends on what we view as a public interface. The stepper interface is breaking but it is absorbed by the Propagator for example. |
With this PR I try to align the naming in the Stepper interface to
qOverP
andabsoluteMomentum
which is also my goal for the track parameters.I pulled these changes out of #2181.