perf: Add option of stereo angle when building telescope detector #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2240 +/- ##
=======================================
Coverage 49.66% 49.66%
=======================================
Files 453 453
Lines 25533 25533
Branches 11706 11706
=======================================
Hits 12680 12680
Misses 4574 4574
Partials 8279 8279 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 60000bdSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
I applied my own suggestions, now my review is not eligible anymore. @felix-russo or @AJPfleger could you have a quick look at this? |
felix-russo
reviewed
Aug 4, 2023
...etectors/TelescopeDetector/include/ActsExamples/TelescopeDetector/BuildTelescopeDetector.hpp
Outdated
Show resolved
Hide resolved
...etectors/TelescopeDetector/include/ActsExamples/TelescopeDetector/BuildTelescopeDetector.hpp
Outdated
Show resolved
Hide resolved
...etectors/TelescopeDetector/include/ActsExamples/TelescopeDetector/BuildTelescopeDetector.hpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/TelescopeDetector/src/BuildTelescopeDetector.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/TelescopeDetector/src/BuildTelescopeDetector.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: felix-russo <[email protected]>
|
@felix-russo can you check back if you're happy with the changes? |
felix-russo
approved these changes
Aug 4, 2023
acts-project-service
added
the
Fails Athena tests
|
Test failure was system-related. |
paulgessinger
removed
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add options for stereo angles of each telescope plane when building the telescope detector, which is helpful in case that the telescope planes are strip detectors with stereo angles.