Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add reco, reco after vertex fit, and truth track momenta to physmon #2221

Merged
merged 49 commits into from
Aug 14, 2023

Conversation

felix-russo
Copy link
Contributor

@felix-russo felix-russo commented Jun 19, 2023

Comparing the reconstructed momenta to their truth values in the physics monitoring. Both the momenta before and after the vertex fit are considered.

@felix-russo felix-russo added the 🚧 WIP Work-in-progress label Jun 19, 2023
@felix-russo felix-russo added this to the next milestone Jun 19, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... labels Jun 19, 2023
@felix-russo felix-russo changed the title CI: Add track momenta at vertex to physmon ci: Add track momenta at vertex to physmon Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2221 (210ddf0) into main (10b40b7) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2221      +/-   ##
==========================================
- Coverage   49.64%   49.63%   -0.01%     
==========================================
  Files         453      453              
  Lines       25538    25540       +2     
  Branches    11708    11709       +1     
==========================================
  Hits        12678    12678              
- Misses       4578     4580       +2     
  Partials     8282     8282              
Files Changed Coverage Δ
Core/include/Acts/Seeding/SpacePointGrid.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Utilities/UnitVectors.hpp 60.71% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger
Copy link
Member

I think the physmon histogram reference file will need an update. @felix-russo do you know how to do this?

@andiwand
Copy link
Contributor

andiwand commented Aug 6, 2023

something is still off with the references here

@felix-russo
Copy link
Contributor Author

felix-russo commented Aug 6, 2023

something is still off with the references here

Yes, it is because the references were changed in the main branch. When I merged, I just kept my references, but since the new code from the main branch changes the physmon, I need to update them again. Sorry for the confusion!

@paulgessinger paulgessinger merged commit d0759c0 into acts-project:main Aug 14, 2023
51 of 53 checks passed
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
@felix-russo felix-russo deleted the momentum-physmon branch August 30, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants