Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Read CSV clusters and measurement-particles-map & refactor #2103

Merged

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented May 6, 2023

!! This breaks the examples file standards !!

  • Enables reading of cluster and optionally reading of measurement-particles-map in CsvMeasurmentReader.
  • Adds a roundtrip-test for the Csv measurment reader/writers. It also provides some generic crazy template stuff which hopefully allows to write round-trip tests in a easy way.
  • There exists a hit_id, which I in the context of the simhit-writer refers to the id of the simulated hit . Additionally to this, there are measurements, which is not a one-to-one mapping. Therefore I would argue we should consistently use the term measurment_id when refering to these measurments.

Should now go in after #2330

@benjaminhuth benjaminhuth added the Component - Examples Affects the Examples module label May 6, 2023
@benjaminhuth benjaminhuth added this to the next milestone May 6, 2023
@benjaminhuth benjaminhuth requested a review from andiwand May 6, 2023 10:55
@benjaminhuth benjaminhuth changed the title refactor: Consistent naming of measurment_id in measurement writer refactor: Consistent naming of measurment_id in writer May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2103 (2d8cb4a) into main (951edca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2103   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25513    25513           
  Branches    11707    11707           
=======================================
  Hits        12649    12649           
  Misses       4579     4579           
  Partials     8285     8285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth added the 🚧 WIP Work-in-progress label May 6, 2023
andiwand
andiwand previously approved these changes May 6, 2023
@github-actions github-actions bot added the Stale label Jun 5, 2023
@github-actions github-actions bot removed the Stale label Jun 16, 2023
@benjaminhuth benjaminhuth changed the title refactor: Consistent naming of measurment_id in writer refactor: Consistent naming of measurment_id and writer-reader-roundtrip Jun 16, 2023
@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Jun 16, 2023
@benjaminhuth
Copy link
Member Author

@asalzburger Just pinnging you to make sure I don't break something accidentally here, since this is also changing the file spec. I also haven't updated the CsvPlanarClusterReader/CsvPlanarClusterWriter (is that infrastructure still needed actually?).

Now it is clear I think that in the EDM we have one cluster per measurement.

I think a next step would be to look again what happens with the clusters in the digitization if we merge measurements.

@paulgessinger
Copy link
Member

Can you resolve the conflicts @benjaminhuth?

@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Aug 14, 2023
@benjaminhuth benjaminhuth changed the title refactor: Consistent naming of measurment_id and writer-reader-roundtrip feat: Read CSV clusters and measurement-particles-map & refactor (breaks file spec!) Aug 14, 2023
@benjaminhuth benjaminhuth changed the title feat: Read CSV clusters and measurement-particles-map & refactor (breaks file spec!) feat: Read CSV clusters and measurement-particles-map & refactor Aug 14, 2023
andiwand
andiwand previously approved these changes Aug 14, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one comment - feel free to ignore

Examples/Io/Csv/src/CsvMeasurementReader.cpp Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Aug 15, 2023
andiwand
andiwand previously approved these changes Aug 15, 2023
@kodiakhq kodiakhq bot merged commit 342899b into acts-project:main Aug 16, 2023
53 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 16, 2023
@paulgessinger
Copy link
Member

I don't see how this could have interacted with the output tests in Athena.

@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants