-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Read CSV clusters and measurement-particles-map & refactor #2103
feat: Read CSV clusters and measurement-particles-map & refactor #2103
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2103 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 453 453
Lines 25513 25513
Branches 11707 11707
=======================================
Hits 12649 12649
Misses 4579 4579
Partials 8285 8285 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 2d8cb4aphysmon summary
|
@asalzburger Just pinnging you to make sure I don't break something accidentally here, since this is also changing the file spec. I also haven't updated the Now it is clear I think that in the EDM we have one cluster per measurement. I think a next step would be to look again what happens with the clusters in the digitization if we merge measurements. |
Can you resolve the conflicts @benjaminhuth? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just one comment - feel free to ignore
I don't see how this could have interacted with the output tests in Athena. |
!! This breaks the examples file standards !!
CsvMeasurmentReader
.hit_id
, which I in the context of the simhit-writer refers to the id of the simulated hit . Additionally to this, there are measurements, which is not a one-to-one mapping. Therefore I would argue we should consistently use the termmeasurment_id
when refering to these measurments.Should now go in after #2330