fix: G4 material converter #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
added
Impact - Major
Codecov Report
@@ Coverage Diff @@
## main #1803 +/- ##
=======================================
Coverage 49.54% 49.54%
=======================================
Files 407 407
Lines 22618 22618
Branches 10318 10318
=======================================
Hits 11207 11207
Misses 4230 4230
Partials 7181 7181 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 9a8774eFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
benjaminhuth
approved these changes
Jan 27, 2023
asalzburger
reviewed
Jan 27, 2023
| @@ -301,12 +303,14 @@ std::shared_ptr<Acts::HomogeneousSurfaceMaterial> | |||
| Acts::Geant4MaterialConverter::surfaceMaterial(const G4Material& g4Material, | |||
| ActsScalar original, | |||
| ActsScalar compressed) { | |||
| assert(g4Material.GetNumberOfElements() == 1); | |||
There was a problem hiding this comment.
In fact, if is a compound, one would have to do the averaging ...
There was a problem hiding this comment.
followed up on this here #1805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nucleus charge VS effective mass
somehow there is no nice solution to get the relative atomic mass in G4 so I had to go through the element class