Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make addSeeding python function smaller #1768

Merged

Conversation

tboldagh
Copy link
Contributor

@tboldagh tboldagh commented Dec 22, 2022

This PR contains changes to the python code configuring seeding. Over time it grew a bit too much.

Tagging @timadye @jahreda

@tboldagh tboldagh added this to the next milestone Dec 22, 2022
@tboldagh tboldagh added the Component - Examples Affects the Examples module label Dec 22, 2022
@tboldagh tboldagh requested review from benjaminhuth, timadye and jahreda and removed request for benjaminhuth December 22, 2022 12:32
@github-actions
Copy link

github-actions bot commented Dec 22, 2022

📊 Physics performance monitoring for e03ec22

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #1768 (e03ec22) into main (675d992) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files         406      406           
  Lines       22567    22567           
  Branches    10307    10307           
=======================================
  Hits        11238    11238           
  Misses       4140     4140           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tboldagh tboldagh marked this pull request as ready for review December 23, 2022 11:20
Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all four seeding algorithms with the ITk full chain, and they gave identical printout (eg. performance summary) between this PR and main.
So apart from the logLevel comment, I'm happy with these changes.

@tboldagh
Copy link
Contributor Author

Re-syncing. Once CI checks out can this be merged? It is needed to continue HT work.

Copy link
Contributor

@jahreda jahreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was told I should click approve despite me not really being the right reviewer :)

@tboldagh
Copy link
Contributor Author

@paulgessinger @asalzburger - can you please allow this to be merged. I wait for this before proceeding with making HT example.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 13, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Jan 13, 2023
@paulgessinger
Copy link
Member

@tboldagh this has picked up conflicts unfortunately. Can you resolve them and then we merge ASAP?

@tboldagh
Copy link
Contributor Author

On it. Seems not to be a small conflict though.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get it done.

@tboldagh
Copy link
Contributor Author

Thanks, let's get it done.

It is resolved. But the CI fails on lsf checkout. Can one restart CI somehow?

@paulgessinger
Copy link
Member

I think it's a transient failure. I retried the jobs, lets see if they succeed.

@kodiakhq kodiakhq bot merged commit 30ed5ee into acts-project:main Jan 13, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants