Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: MTJ uncalibrated -> uncalibratedSourceLink #1766

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

paulgessinger
Copy link
Member

Closes #1613.
This changes the uncalibrated source link access functions to be symmetric with the calibrated functions.

Closes acts-project#1613.
This changes the uncalibrated source link access functions to be
symmetric with the calibrated functions.
@paulgessinger paulgessinger added this to the next milestone Dec 21, 2022
@paulgessinger
Copy link
Member Author

@tboldagh

Copy link
Contributor

@tboldagh tboldagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It will be clearer now. Thanks Paul

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #1766 (64eb3a7) into main (3d30908) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1766   +/-   ##
=======================================
  Coverage   49.46%   49.46%           
=======================================
  Files         399      399           
  Lines       22102    22102           
  Branches    10031    10031           
=======================================
  Hits        10932    10932           
  Misses       4203     4203           
  Partials     6967     6967           
Impacted Files Coverage Δ
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 31.11% <0.00%> (ø)
Core/include/Acts/TrackFitting/Chi2Fitter.hpp 35.34% <0.00%> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp 43.19% <0.00%> (ø)
...e/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp 12.28% <0.00%> (ø)
Core/include/Acts/EventData/MultiTrajectory.ipp 57.89% <50.00%> (ø)
Core/include/Acts/EventData/MultiTrajectory.hpp 71.11% <75.00%> (ø)
...e/include/Acts/EventData/VectorMultiTrajectory.hpp 60.75% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger modified the milestone: next Dec 21, 2022
@github-actions
Copy link

📊 Physics performance monitoring for 64eb3a7

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger paulgessinger merged commit f242aae into acts-project:main Dec 21, 2022
@paulgessinger paulgessinger deleted the refactor/uncalib-src branch December 21, 2022 12:54
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 5, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 6, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 15, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 15, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncalibrated and calibrated source links in MultiTrajectory should have symmetric access API
2 participants