feat: Geant4 detector plugin, part 2 #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Component - Plugins
Codecov Report
@@ Coverage Diff @@
## main #1759 +/- ##
=======================================
Coverage 49.66% 49.66%
=======================================
Files 403 403
Lines 22406 22406
Branches 10240 10240
=======================================
Hits 11127 11127
Misses 4135 4135
Partials 7144 7144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for b84bc26Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Dec 21, 2022
asalzburger
force-pushed
the
feat-geant4-add-json-infrastructure
branch
from
a8d8b29
to
eec0b5b
Compare
|
This one is now quite a lot smaller ... |
asalzburger
added a commit
that referenced
this pull request
Jan 11, 2023
This PR concludes (for the moment) the Geant4 based detector example, it adds at the `Detector/Geant4` to the Examples, adds the python bindings. It is currently blocked as it depends on #1758 and #1759 - the first two parts of this development. With this PR, relatively simple GDML files can be translated one-to-one into a `TrackingGeometry`, it serves as a validation test bench, and will also provide future translation into `Experimental::Detector` in order to cross-validate. The following shows an output of a 'light' version of the ODD tracker:   This can be reproduced with the following sources: [odd-light.zip](https://github.com/acts-project/acts/files/10247296/odd-light.zip) This contains: ```sh -rwxr-xr-x@ 1 salzburg staff 991 Dec 16 16:58 gdml_geometry.py -rwxr-xr-x@ 1 salzburg staff 2156 Dec 16 16:57 gdml_material_recording.py -rwxr-xr-x@ 1 salzburg staff 1926 Dec 16 16:57 gdml_material_validation.py -rw-r--r--@ 1 salzburg staff 6434606 Dec 16 16:56 odd-light.gdml -rw-r--r-- 1 salzburg staff 79113 Dec 16 16:55 odd-proto-detector.json ``` The `odd-light.gdml` is the GDML description of the detector, the `odd-proto-detector.json` the structure and then are three run files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Json infrastructure to read and write the proto detector description.
It includes #1758 and is blocked until this one is merged.