fix: Multistepper error condition #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Bug
benjaminhuth
force-pushed
the
fix/multistepper-error-condition
branch
from
1adc9d0
to
e3648a9
Compare
📊 Physics performance monitoring for e3648a9Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #1747 +/- ##
=======================================
Coverage 49.20% 49.20%
=======================================
Files 398 398
Lines 21853 21853
Branches 9916 9916
=======================================
Hits 10753 10753
Misses 4222 4222
Partials 6878 6878
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
approved these changes
Dec 14, 2022
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
There was a wrong abort condition in the `EigenMultiStepperLoop`'s step function, I think a leftover from a previous refactoring. This could lead to rare cases of not aborting the propagation, if all components have a stepping failure. The new condition should fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a wrong abort condition in the
EigenMultiStepperLoop's step function, I think a leftover from a previous refactoring. This could lead to rare cases of not aborting the propagation, if all components have a stepping failure.The new condition should fix this.