Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track 2d/z and track 3d signed lifetimes #1741

Merged
merged 14 commits into from
Jan 9, 2023

Conversation

pbutti
Copy link
Contributor

@pbutti pbutti commented Dec 13, 2022

This PR is to add couple of methods from the Athena TrackToVertexIPEstimator. In particular the 3d, 2d and Z signed lifetimes with respect to a given direction, i.e. a jet direction, are provided.
The computation follows the methods largely used by atlas here:
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Tracking/TrkVertexFitter/TrkVertexFitterUtils/src/TrackToVertexIPEstimator.cxx#0230

The interface is kept as simple as possible, without using the intermediate VertexFinder::State.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1741 (186f008) into main (ae2811f) will decrease coverage by 0.00%.
The diff coverage is 43.24%.

@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
- Coverage   49.66%   49.65%   -0.01%     
==========================================
  Files         403      404       +1     
  Lines       22406    22435      +29     
  Branches    10240    10258      +18     
==========================================
+ Hits        11127    11141      +14     
+ Misses       4135     4132       -3     
- Partials     7144     7162      +18     
Impacted Files Coverage Δ
...e/include/Acts/TrackFitting/BetheHeitlerApprox.hpp 24.00% <0.00%> (-0.57%) ⬇️
...re/include/Acts/Vertexing/ImpactPointEstimator.hpp 100.00% <ø> (ø)
...re/include/Acts/Vertexing/ImpactPointEstimator.ipp 38.23% <41.17%> (+0.58%) ⬆️
Core/src/TrackFitting/BetheHeitlerApprox.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pbutti
Copy link
Contributor Author

pbutti commented Dec 13, 2022

I will fix the clang-format and the docs.

@github-actions
Copy link

github-actions bot commented Dec 13, 2022

📊 Physics performance monitoring for 186f008

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@benjaminhuth benjaminhuth added this to the next milestone Dec 15, 2022
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pbutti, can you fix the format check. Also would you consider adding two tiny unit tests to ImpactPointEstimatoeTests.cpp just so we have this functionality covered.

Core/include/Acts/Vertexing/ImpactPointEstimator.hpp Outdated Show resolved Hide resolved
@pbutti pbutti force-pushed the feature-track2DZlifetimesSign branch from 187fce7 to eac937c Compare December 22, 2022 14:57
@kodiakhq kodiakhq bot merged commit 45fb8b8 into acts-project:main Jan 9, 2023
@github-actions github-actions bot removed the automerge label Jan 9, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
@pbutti pbutti deleted the feature-track2DZlifetimesSign branch February 8, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants