Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: SourceLink uses custom Acts::Any #1740

Merged

Conversation

paulgessinger
Copy link
Member

This should be a transparent change in terms of the interface.

@paulgessinger paulgessinger added this to the next milestone Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1740 (6f3ec27) into main (4e60261) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1740   +/-   ##
=======================================
  Coverage   49.20%   49.20%           
=======================================
  Files         398      398           
  Lines       21847    21850    +3     
  Branches     9913     9914    +1     
=======================================
+ Hits        10750    10752    +2     
  Misses       4222     4222           
- Partials     6875     6876    +1     
Impacted Files Coverage Δ
Core/include/Acts/EventData/SourceLink.hpp 84.61% <100.00%> (+9.61%) ⬆️
Core/include/Acts/Utilities/Any.hpp 72.72% <0.00%> (-0.76%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand andiwand added Component - Core Affects the Core module automerge labels Dec 13, 2022
@andiwand andiwand self-assigned this Dec 13, 2022
@github-actions
Copy link

github-actions bot commented Dec 13, 2022

📊 Physics performance monitoring for 6f3ec27

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit d4aac95 into acts-project:main Dec 13, 2022
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
This should be a transparent change in terms of the interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants