fix: MultiTrajectory specialize DynamicColumn for bool #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As vector is specialized on bool, which prevents getting references to the underlying bool mechanisms, we have to specialize `DynamiColumn` to break this specialization of vector.
📊 Physics performance monitoring for 37e33a7Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
There are no references to the |
Codecov Report
@@ Coverage Diff @@
## main #1730 +/- ##
==========================================
- Coverage 49.27% 49.27% -0.01%
==========================================
Files 398 398
Lines 21763 21764 +1
Branches 9874 9875 +1
==========================================
Hits 10724 10724
Misses 4174 4174
- Partials 6865 6866 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pbutti
pushed a commit
to pbutti/acts
that referenced
this pull request
Dec 13, 2022
…1730) As vector is specialized on bool, which prevents getting references to the underlying bool mechanisms, we have to specialize `DynamiColumn` to break this specialization of vector. I'm also rolling in another small const-correctness fix to dynamic columns into this PR.
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
…1730) As vector is specialized on bool, which prevents getting references to the underlying bool mechanisms, we have to specialize `DynamiColumn` to break this specialization of vector. I'm also rolling in another small const-correctness fix to dynamic columns into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As vector is specialized on bool, which prevents getting references to the underlying bool mechanisms, we have to specialize
DynamiColumnto break this specialization of vector.I'm also rolling in another small const-correctness fix to dynamic columns into this PR.