Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track modifier for examples #1726

Merged
merged 8 commits into from
Dec 13, 2022

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Dec 8, 2022

while dealing with vertexing issues I thought adding a track parameter modification algorithm to the examples framework might be useful

another try of #1658

@andiwand andiwand force-pushed the feature-example-track-modifier branch from a664764 to ef54955 Compare December 8, 2022 17:04
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1726 (1f3cab2) into main (e63cc25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1f3cab2 differs from pull request most recent head 6e1d474. Consider uploading reports for the commit 6e1d474 to get more accurate results

@@           Coverage Diff           @@
##             main    #1726   +/-   ##
=======================================
  Coverage   49.21%   49.21%           
=======================================
  Files         398      398           
  Lines       21827    21831    +4     
  Branches     9904     9906    +2     
=======================================
+ Hits        10742    10744    +2     
  Misses       4216     4216           
- Partials     6869     6871    +2     
Impacted Files Coverage Δ
...lude/Acts/EventData/SingleBoundTrackParameters.hpp 58.97% <100.00%> (+1.07%) ⬆️
Core/include/Acts/TrackFitting/Chi2Fitter.hpp 35.23% <0.00%> (-0.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

📊 Physics performance monitoring for 6e1d474

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some things in the modifier-lambda are not entirely clear to me yet

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@benjaminhuth benjaminhuth added Component - Examples Affects the Examples module automerge labels Dec 13, 2022
@benjaminhuth benjaminhuth added this to the next milestone Dec 13, 2022
@kodiakhq kodiakhq bot merged commit 0b19284 into acts-project:main Dec 13, 2022
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
while dealing with vertexing issues I thought adding a track parameter modification algorithm to the examples framework might be useful

another try of acts-project#1658
@andiwand andiwand deleted the feature-example-track-modifier branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants