Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: python reconstruction trajectory writing #1718

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Dec 8, 2022

rearrange writing mechanism for trajectories and reuse it for ambires and others in the future

@andiwand andiwand added the Component - Examples Affects the Examples module label Dec 8, 2022
@andiwand andiwand added this to the next milestone Dec 8, 2022
@paulgessinger
Copy link
Member

I'll have to touch this again when Track is done, but let's go ahead with this in any case.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1718 (4eeef8d) into main (f4ec72a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   49.65%   49.65%           
=======================================
  Files         404      404           
  Lines       22435    22435           
  Branches    10258    10258           
=======================================
  Hits        11141    11141           
  Misses       4132     4132           
  Partials     7162     7162           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

📊 Physics performance monitoring for 4eeef8d

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand
Copy link
Contributor Author

andiwand commented Dec 8, 2022

I'll have to touch this again when Track is done, but let's go ahead with this in any case.

I feel like I am breaking the python interface on a weekly basis right now but I don't really see a way around this

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I think I forgot this somehow, but I let's get this in now.

@kodiakhq kodiakhq bot merged commit 04f21ac into acts-project:main Jan 10, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
@andiwand andiwand deleted the refactor-python-trajectory-writers branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants