Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hough Transform first implementation clang-tidy #1691

Merged
merged 1 commit into from
Nov 25, 2022
Merged

fix: Hough Transform first implementation clang-tidy #1691

merged 1 commit into from
Nov 25, 2022

Conversation

andiwand
Copy link
Contributor

based on #1305

clang tidy fixes

@andiwand andiwand added Component - Examples Affects the Examples module 🛑 blocked This item is blocked by another item labels Nov 23, 2022
@andiwand andiwand added this to the next milestone Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #1691 (2b88c72) into main (980f9ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage   48.95%   48.95%           
=======================================
  Files         397      397           
  Lines       21509    21509           
  Branches     9806     9806           
=======================================
  Hits        10530    10530           
  Misses       4181     4181           
  Partials     6798     6798

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 23, 2022 •
edited
Loading

📊 Physics performance monitoring for 2b88c72

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

❌ Seeding truth_smeared

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

AJPfleger
AJPfleger reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my other comments: I am not quite sure if everything with the ///-doxygen comments should have them and vice versa. Maybe if you have time, you could have a look over them again.

Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/DefaultHoughFunctions.hpp Outdated Show resolved Hide resolved
Examples/Algorithms/TrackFinding/src/HoughTransformSeeder.cpp Outdated Show resolved Hide resolved
Examples/Algorithms/TrackFinding/src/HoughTransformSeeder.cpp Outdated Show resolved Hide resolved
Examples/Algorithms/TrackFinding/src/HoughTransformSeeder.cpp Outdated Show resolved Hide resolved
Examples/Algorithms/TrackFinding/src/HoughTransformSeeder.cpp Outdated Show resolved Hide resolved
Examples/Algorithms/TrackFinding/src/HoughTransformSeeder.cpp Outdated Show resolved Hide resolved
@andiwand
Copy link
Contributor Author

thanks for your comments @AJPfleger but I fear they should go here #1305

my PR is only there to fix the clang tidy issues

@asalzburger this seems to pass so you could merge the original PR and this one on top to fix the CI

@andiwand andiwand mentioned this pull request Nov 24, 2022
Merged
asalzburger
asalzburger approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I included Alexander's suggestion.

@asalzburger
Copy link
Contributor

Updating the branch with main.

@asalzburger
Copy link
Contributor

asalzburger commented Nov 24, 2022 •
edited
Loading

Meh, that was stupid of me, I have merged Alexander's suggestions into that ... and broke the build, because no logger was defined in the algorithm ...

@asalzburger
Copy link
Contributor

@andiwand - I think best is we make a cherrypick version with only the clang-tidy commit.

@andiwand
Copy link
Contributor Author

@asalzburger I reverted to my original commit so this should be mergable again

@asalzburger
Copy link
Contributor

Thanks!

@asalzburger asalzburger removed the 🛑 blocked This item is blocked by another item label Nov 24, 2022
@asalzburger
Copy link
Contributor

Hi @andiwand - the original Hough Transform PR is merged, but I see some conflicts now, can you try to resolve?

@andiwand
Copy link
Contributor Author

@asalzburger conflicts should be gone now 👍

@asalzburger asalzburger merged commit c7d009f into acts-project:main Nov 25, 2022
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
@andiwand @pbutti
fix: Hough Transform first implementation clang-tidy (acts-project#1691)
836a09a 
based on acts-project#1305

clang tidy fixes
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
@andiwand
fix: Hough Transform first implementation clang-tidy (acts-project#1691)
af25f9e 
based on acts-project#1305

clang tidy fixes
@andiwand andiwand deleted the jahredaHTDev-clang-tidy branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger left review comments

@asalzburger asalzburger asalzburger approved these changes

Assignees

@asalzburger asalzburger

Labels
Component - Examples Affects the Examples module
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andiwand @asalzburger @AJPfleger @paulgessinger