fix: OwningDelegate holder type #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed a combination in the test and one typedef mismatch
asalzburger
approved these changes
Nov 17, 2022
|
Thanks @paulgessinger for the quick fix, that makes totally sense now. |
andiwand
approved these changes
Nov 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #1679 +/- ##
==========================================
- Coverage 48.59% 48.58% -0.01%
==========================================
Files 382 382
Lines 21061 21061
Branches 9644 9645 +1
==========================================
- Hits 10234 10233 -1
Misses 4147 4147
- Partials 6680 6681 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
Missed a combination in the test and one typedef mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a combination in the test and one typedef mismatch