Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: how to get clang-format changes from CI #1667

Merged
merged 3 commits into from
Nov 11, 2022
Merged

docs: how to get clang-format changes from CI #1667

merged 3 commits into from
Nov 11, 2022

Conversation

jahreda
Copy link
Contributor

@jahreda jahreda commented Nov 9, 2022 •
edited by paulgessinger
Loading

Add explanation of how to download clang-format recommended changes from the CI job

@jahreda
Update run_formatting.md
56cb938 
Add explanation of how to download clang-format recommended changes from the CI job
@jahreda jahreda changed the title Update run_formatting.md docs: Update run_formatting.md Nov 9, 2022
@AJPfleger AJPfleger added this to the next milestone Nov 10, 2022
AJPfleger
AJPfleger requested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, maybe you could adapt some things in this PR:

  • [solved] More expressive title e.g. docs: how to get clang-format changes from CI
  • [solved] Edit first comment (You still have the reminder text in it)

docs/contribution/run_formatting.md Show resolved Hide resolved
@AJPfleger AJPfleger added the Component - Documentation Affects the documentation label Nov 10, 2022
@paulgessinger paulgessinger changed the title docs: Update run_formatting.md docs: How to get formatted files from the CI Nov 10, 2022
@jahreda jahreda changed the title docs: How to get formatted files from the CI docs: how to get clang-format changes from CI Nov 10, 2022
@kodiakhq kodiakhq bot merged commit f66119a into acts-project:main Nov 11, 2022
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
@jahreda
docs: how to get clang-format changes from CI (acts-project#1667)
3f97008 
Add explanation of how to download clang-format recommended changes from the CI job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Documentation Affects the documentation
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jahreda @andiwand @AJPfleger @paulgessinger @benjaminhuth